Postgres Pro
Downloads
Home   >   mailing lists

Free indexed_tlist memory explicitly within set_plan_refs() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Free indexed_tlist memory explicitly within set_plan_refs()
Date
Msg-id CAM3SWZS+CauzbiCEcg-GdE6K6ycHE_Bz6Ksszy8AoixcMHOmsA@mail.gmail.com
Whole thread Raw
Responses Re: Free indexed_tlist memory explicitly within set_plan_refs()  (Michael Paquier <michael.paquier@gmail.com>)
Re: Free indexed_tlist memory explicitly within set_plan_refs()  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Tree view 
While trying to fix a largely unrelated bug, I noticed that the new
build_tlist_index() call for the "excluded" targetlist (used by ON
CONFLICT DO UPDATE queries) does not have its memory subsequently
freed by the caller. Since every other call to build_tlist_index()
does this, and comments above build_tlist_index() encourage it, I
think the new caller should do the same.

Attached patch adds such a pfree() call.
--
Peter Geoghegan
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: problems on Solaris
Next
From: Bruce Momjian
Date:
Subject: Re: Run pgindent now?