Postgres Pro
Downloads
Home   >   mailing lists

Re: [BUG] pg_basebackup from disconnected standby fails - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [BUG] pg_basebackup from disconnected standby fails
Date
Msg-id CAB7nPqQk2O6b7t51=rPWWd3YNu-7FHMyy4ESaw6qnAvhjPoZxQ@mail.gmail.com
Whole thread Raw
In response to Re: [BUG] pg_basebackup from disconnected standby fails  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Oct 26, 2016 at 6:13 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> If my understanding is right, then the changes proposed by you as
> below is not what is intended here.  I think you need to do something
> as I have mentioned above.

Ah OK I have spotted the subtility;
- 0 means update minRecoveryPoint to the LSN *passed* by the caller
- 1 means update minRecoveryPoint to the *latest replayed* LSN and not
the one of the caller
But if we do so that would mean an extra update of the control file
for nothing in CreateRestartPoint(), and that serves nothing.
-- 
Michael

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [BUG] pg_basebackup from disconnected standby fails
Next
From: Michael Paquier
Date:
Subject: Re: what to do about unsupported encodings