- Mailing list pgsql-hackers

From Michael Paquier
Subject
Date
Msg-id CAB7nPqQe83Pi76Mc5R1=wObOH-w0QZ1QRnVEK0GU6kMSB5ZhVQ@mail.gmail.com
Whole thread Raw
Responses Re:  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers


On Mon, Dec 7, 2015 at 11:37 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
The latest patch has another problem; pg_receivexlog trying to connect to
the PostgreSQL >= 9.4 always reports the following message unexpectedly.

could not identify system: got 1 rows and 4 fields, expected 1 rows
and 4 or more fields

This problem happens because the patch incorrectly treats the case where
IDENTIFY_SYSTEM command returns NULL as database name, as an error case.

Attached is the updated version of the patch, which fixes the problem.
Comments?

The patch looks good. The top comment of RunIdentifySystem is incorrect though. It should mention that a database name is returned and not a plugin name.
--
Michael

pgsql-hackers by date:

Previous
From: Andreas Seltenreich
Date:
Subject: Re: [sqlsmith] Failed to generate plan on lateral subqueries
Next
From: Michael Paquier
Date:
Subject: Re: pg_receivexlog: spurious error message connecting to 9.3