Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write,the standby fails to start. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write,the standby fails to start.
Date
Msg-id CAB7nPqQafwnsKAZ9sv9D8wE_3HU6gge6L0QuPXp9yK=4-2oC1A@mail.gmail.com
Whole thread Raw
In response to [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write, thestandby fails to start.  ("Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>)
Responses Re: [HACKERS] [Bug fix]If recovery.conf hastarget_session_attrs=read-write, the standby fails to start.  ("Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>)
Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write,the standby fails to start.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, May 19, 2017 at 1:16 PM, Higuchi, Daisuke
<higuchi.daisuke@jp.fujitsu.com> wrote:
> The reason of this problem is that sending 'show transaction_read_only' is failed.
> 'show' must be in uppercase letters because the streaming replication protocol only accepts capital letters.
> In psql and libpq applications that do not use the streaming replication protocol, this error does not occur.
>
> The attached patch fixes this. This patch changes 'show transaction_read_only' to 'SHOW transaction_read_only'.
                    if (!PQsendQuery(conn,
-                                     "show transaction_read_only"))
+                                     "SHOW transaction_read_only"))
Or perhaps the replication command parser could be made more flexible
with lower-case characters for replication commands?
-- 
Michael



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] different column orders in regression test database
Next
From: Thomas Munro
Date:
Subject: Re: [HACKERS] transition table behavior with inheritance appearsbroken (was: Declarative partitioning - another take)