Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Fix bloom WAL tap test - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Fix bloom WAL tap test
Date
Msg-id CAB7nPqQZKuWvePUvcVGk9F+rjPYxPSPfwrZSE9BztAuxLuEzgA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Fix bloom WAL tap test  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: [HACKERS] Fix bloom WAL tap test  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Thu, Nov 9, 2017 at 7:51 PM, Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
> On Wed, Nov 8, 2017 at 5:46 AM, Masahiko Sawada <sawada.mshk@gmail.com>
> wrote:
>> > So I think
>> > that you should instead do something like that:
>> >
>> > --- a/contrib/bloom/Makefile
>> > +++ b/contrib/bloom/Makefile
>> > @@ -20,5 +20,12 @@ include $(top_builddir)/src/Makefile.global
>> >  include $(top_srcdir)/contrib/contrib-global.mk
>> >  endif
>> >
>> > +installcheck: wal-installcheck
>> > +
>> > +check: wal-check
>> > +
>> > +wal-installcheck:
>> > +   $(prove_installcheck)
>> > +
>> >  wal-check: temp-install
>> >     $(prove_check)
>> >
>> > This works for me as I would expect it should.
>>
>> Looks good to me too.
>
> OK, then so be it :)

Thanks for the new version. This one, as well as the switch to
psql_safe in https://www.postgresql.org/message-id/CAPpHfduxgEYF_0BTs-mxGC4=w5sw8rnUbq9BSTp1Wq7=NwrWDA@mail.gmail.com
are good for a committer lookup IMO.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Mark Rofail
Date:
Subject: Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Simplify ACL handling for large objects and removal of superuser() checks