<div dir="ltr">On Sat, Jan 24, 2015 at 5:58 AM, Alvaro Herrera <span dir="ltr"><<a
href="mailto:alvherre@2ndquadrant.com"target="_blank">alvherre@2ndquadrant.com</a>></span> wrote:<br /><div
class="gmail_extra"><divclass="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px
#cccsolid;padding-left:1ex">Here's v0.5. (Why did you use that weird decimal versioning scheme? You<br /> could just
say"v4" and save a couple of keystrokes). This patch makes<br /> perfect sense to me now. I was ready to commit, but
Ichecked the<br /> regression test you added and noticed that you're only reading results<br /> for the last set of
operationsbecause they all use the same table and<br /> so each new set clobbers the values for the previous one. So I
modified<br/> them to use one table for each set, and report the counters for all<br /> tables. In doing this I
noticedthat the one for trunc_stats_test3 is<br /> at odds with what your comment in the .sql file says; would you
review<br/> it please? Thanks.<br /><br /> (I didn't update the expected file.)<br /><br /> BTW you forgot to update
expected/prepared_xact_1.out,for the case when<br /> prep xacts are disabled.<br /><br /> If some other committer
decidesto give this a go, please remember to<br /> bump catversion before pushing.<br /></blockquote></div><br
/></div><divclass="gmail_extra">Alex, this patch seems nicely backed. Could you review the changes of Alvaro? This
threadis waiting for your input for 3 weeks.<br />-- <br /><div class="gmail_signature">Michael<br /></div></div></div>
