Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Broken O(n^2) avoidance in wal segment recycling. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Broken O(n^2) avoidance in wal segment recycling.
Date
Msg-id CAB7nPqQPrFefK2fj8Y0WSG4rf9LaigD0ithEeabtb2fvhDQ3+g@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Broken O(n^2) avoidance in wal segment recycling.  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] Broken O(n^2) avoidance in wal segment recycling.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Jun 22, 2017 at 6:10 AM, Andres Freund <andres@anarazel.de> wrote:
> We've not heard any complaints about this afaik, but it's not something
> that's easily diagnosable as being a problem.  Therefore I suspect we
> should fix and backpatch this?

Agreed. I have just poked at this problem and have finished with the
attached. Logically it is not complicated at the argument values used
by the callers of RemoveXlogFile() are never updated when scanning
pg_wal. Surely this patch needs an extra pair of eyes.
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Setting pd_lower in GIN metapage
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Setting pd_lower in GIN metapage