Re: TABLESAMPLE patch - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TABLESAMPLE patch
Date
Msg-id CAB7nPqQHyRrNzriqnG8Eq9o73Hiz4Pt_NByW+Enz3tDSMkdVDA@mail.gmail.com
Whole thread Raw
In response to Re: TABLESAMPLE patch  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: TABLESAMPLE patch
List pgsql-hackers
On Sat, Apr 18, 2015 at 8:38 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote:
>> On 10/04/15 06:46, Michael Paquier wrote:
>>> 13) Some regression tests with pg_tablesample_method would be welcome.
>>
>> Not sure what you mean by that.
>
> I meant a sanity check on pg_tablesample_method to be sure that
> tsminit, tsmnextblock and tsmnexttuple are always defined as they are
> mandatory functions. So the idea is to add a query like and and to be
> sure that it returns no rows:
> SELECT tsmname FROM pg_tablesample_method WHERE tsminit IS NOT NULL OR
> tsmnextblock IS NOT NULL OR tsmnexttuple IS NOT NULL;

Yesterday was a long day. I meant IS NULL and not IS NOT NULL, but I
am sure you guessed it that way already..
-- 
Michael



pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: mogrify and indent features for jsonb
Next
From: Michael Paquier
Date:
Subject: Re: Supporting src/test/modules in MSVC builds