Re: pgsql: Run the C portions of guc-file.l through pgindent. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Run the C portions of guc-file.l through pgindent.
Date
Msg-id CAB7nPqQHDOx9-pnPwLQfcbD42=efFthCvP_mKVyCzP0BMaeT8Q@mail.gmail.com
Whole thread Raw
In response to pgsql: Run the C portions of guc-file.l through pgindent.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Run the C portions of guc-file.l through pgindent.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Mon, Jun 29, 2015 at 9:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Run the C portions of guc-file.l through pgindent.
>
> Yeah, I know, pretty anal-retentive of me.  But we oughta find some
> way to automate this for the .y and .l files.

.y files may be tricky and .l files less. Still one good way to test
such things would be to use something like that and see at least what
happens when doing a run (haven't tested, use at your own risk):
diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent
index 0d3859d..3995214 100755
--- a/src/tools/pgindent/pgindent
+++ b/src/tools/pgindent/pgindent
@@ -519,6 +519,7 @@ File::Find::find(
                        (($dev, $ino, $mode, $nlink, $uid, $gid) = lstat($_))
                          && -f _
                          && /^.*\.[ch]\z/s
+                         && /^.*\.(h|c|y|l)\z/s
                          && push(@files, $File::Find::name);
                  }
        },

Regards,
--
Michael


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Run the C portions of guc-file.l through pgindent.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates