<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Sat, Aug 22, 2015 at 12:55 AM, Alvaro
Herrera<span dir="ltr"><<a href="mailto:alvherre@2ndquadrant.com"
target="_blank">alvherre@2ndquadrant.com</a>></span>wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px#ccc solid;padding-left:1ex"><span class="">Michael Paquier wrote:<br /><br /> > if
(needlabel)<br/> > appendStringInfo(buf, "::%s",<br /> > -<br /> >
format_type_with_typemod(node->consttype,<br/> > -<br /> > node->consttypmod));<br /> > +<br /> >
format_type_be_qualified(node->consttype));<br/> > Pondering more about this one, I think that we are going to
needa new<br /> > routine in format_type.c to be able to call format_type_internal as<br /> >
format_type_internal(type_oid,typemod, true/false, false, true). If<br /> > typemod is -1, then typemod_given (the
thirdargument) is false, otherwise<br /> > typemod_given is true. That's close to what the C function format_type
at<br/> > the SQL level can do except that we want it to be qualified. Regression<br /> > tests will need an
updateas well.<br /><br /></span>I don't know what's going on here, but please look at the patch posted<br /> by
AlexanderShulgin in the thread about JSON DDL deparse today; there's<br /> some additional stuff in format_type.c there
thatis probably useful to<br /> share between these two patches.</blockquote></div><br /></div><div
class="gmail_extra">Oh,OK. That's good to know. I'll have a look at it. I think that it may be possible to extract a
singlepatch usable for both facilities.<br />-- <br /><div class="gmail_signature">Michael<br /></div></div></div>
