Re: [HACKERS] contrib modules and relkind check - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] contrib modules and relkind check
Date
Msg-id CAB7nPqQARd9q6fzp=YUSSkSy7dJEGneRjnvir+wxBqtnVE36ZA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] contrib modules and relkind check  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Fri, Mar 10, 2017 at 9:34 AM, Stephen Frost <sfrost@snowman.net> wrote:
> * Michael Paquier (michael.paquier@gmail.com) wrote:
>> Thanks. Shouldn't this fix be back-patched? pg_visibility should fail
>> properly for indexes and other relkinds even in 9.6. pgstattuple can
>> also trigger failures. It would be confusing for users to face "could
>> not open file" kind of errors instead of a proper error message. Note
>> that I am fine to produce those patches if there is a resource issue
>> for any of you two.
>
> I'm not really convinced that back-patching this is worthwhile, which is
> why I didn't go through the effort to do so.  A reasonable error will be
> thrown in either case, after all, without any bad behavior happening,
> from what I can see.

Okay, I don't mind as nobody has complained about pgstattuple in particular.

> That said, if you feel strongly enough about it to propose appropriate
> patches for the back-branches, I'll try and look at them before the next
> set of point releases, but I'm not going to deal with them this month as
> I'd like to get through as much of the CF for PG10 as we can.

Nah, let's see if somebody else complains.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: [HACKERS] Re: [COMMITTERS] pgsql: Throw an error if a DATA() line containswrong # of attributes.
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Should buffer of initialization fork have aBM_PERMANENT flag