Re: Fix Error Message for allocate_recordbuf() Failure - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix Error Message for allocate_recordbuf() Failure
Date
Msg-id CAB7nPqQA7=mgXdMNrQOZ8c7LcmqJ8j5HE_8WojWD+=bnUgtFbg@mail.gmail.com
Whole thread Raw
In response to Re: Fix Error Message for allocate_recordbuf() Failure  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Wed, Sep 21, 2016 at 10:25 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Sep 21, 2016 at 12:32 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> For what it's worth, I think it's fine.  Good error messages are a useful thing.
>>
>> More generally, I think the whole patch looks good and should be committed.
>
> Hm. I'd think that it is still more portable to just issue a WARNING
> message in palloc_extended() when MCXT_ALLOC_NO_OOM then. Other code
> paths could benefit from that as well, and the patch proposed does
> nothing for the other places calling it. I am fine to write a patch
> for this purpose if you agree on that.

Or in short the attached. All the other callers of palloc_extended
benefit from that.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: New SQL counter statistics view (pg_stat_sql)
Next
From: Dilip Kumar
Date:
Subject: Re: Speed up Clog Access by increasing CLOG buffers