Re: Using 128-bit integers for sum, avg and statistics aggregates - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Using 128-bit integers for sum, avg and statistics aggregates
Date
Msg-id CAB7nPqQ93xNR4oLAsrBR=pkSJ75eP1ZEGq=AH_LN+8t_AgjHKA@mail.gmail.com
Whole thread Raw
In response to Re: Using 128-bit integers for sum, avg and statistics aggregates  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Using 128-bit integers for sum, avg and statistics aggregates
List pgsql-hackers
On Sun, Mar 22, 2015 at 6:22 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On March 22, 2015 6:17:28 AM GMT+01:00, Michael Paquier <michael.paquier@gmail.com> wrote:
>>On Sun, Mar 22, 2015 at 12:32 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Andres Freund <andres@2ndquadrant.com> writes:
>>>> Pushed with that additional change. Let's see if the buildfarm
>>thinks.
>>>
>>> jacana, apparently alone among buildfarm members, does not like it.
>>
>>All the windows nodes don't pass tests with this patch, the difference
>>is in the exponential precision: e+000 instead of e+00.
>
> That's due to a different patch though, right? When I checked earlier only jacana had problems due to this, and it
lookedlike random memory was being output. It's interesting that that's on the one windows (not cygwin) critter that
doesthe 128bit dance... 

Yes, sorry, the e+000 stuff is from 959277a. This patch has visibly broken that:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2015-03-21%2003%3A01%3A21
--
Michael



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Lets delete src/test/performance
Next
From: David Rowley
Date:
Subject: Re: Using 128-bit integers for sum, avg and statistics aggregates