Postgres Pro
Downloads
Home   >   mailing lists

XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine - Mailing list pgsql-hackers

From Michael Paquier
Subject XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine
Date
Msg-id CAB7nPqQ-x=JU1R6a+Jx-wmcTnFWWLneWEPyLD+re6R23=1YnJw@mail.gmail.com
Whole thread Raw
Responses Re: XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Tree view
Hi all,

While reading the code in this area this morning, I noticed that wal_log_hints and track_commit_timestamp are not mentioned in the desc routine of XLOG_CHANGE_PARAMETER. Also, it is not mentioned in postgresql.conf.sample that a value update of wal_log_hints requires a system restart.

In order to fix those things, attached are two patches:
- patch 1 should be applied back to 9.4 where wal_log_hints has been added
- patch 2 is master-only, and needs to be applied on top of patch 1.
Regards,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [REVIEW] Re: Compression of full-page-writes
Next
From: Adam Brightwell
Date:
Subject: check-world failure: dummy_seclabel