Re: pg_dump, pg_dumpall and data durability - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_dump, pg_dumpall and data durability
Date
Msg-id CAB7nPqQ+fzsCGeE2dqN+275JeSGEBFSBp7Oau+tX4ckiz-=bjg@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump, pg_dumpall and data durability  (Albe Laurenz <laurenz.albe@wien.gv.at>)
Responses Re: pg_dump, pg_dumpall and data durability  (Robert Haas <robertmhaas@gmail.com>)
Re: pg_dump, pg_dumpall and data durability  (Albe Laurenz <laurenz.albe@wien.gv.at>)
List pgsql-hackers
On Tue, Nov 8, 2016 at 1:24 AM, Albe Laurenz <laurenz.albe@wien.gv.at> wrote:
> The patch does not apply, I had to change the hunk for
> src/include/common/file_utils.h.

Yes, the patch has rotten a bit because of f82ec32a. 5d58c07a has also
made the --noxxx option names appearing as --no-xxx.

> Also, compilation fails because function "pre_fsync_fname" cannot be
> resolved during linking. Is that a typo for "pre_fsync_fname" or is
> the patch incomplete?

A typo s/pre_fsync_fname/pre_sync_fname, and a mistake from me because
I did not compile with -DPG_FLUSH_DATA_WORKS to check this code.

v2 is attached, fixing those issues.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: add more NLS to bin
Next
From: Michael Paquier
Date:
Subject: Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled