Re: Fix overflow in DecodeInterval - Mailing list pgsql-hackers

From Joseph Koshakow
Subject Re: Fix overflow in DecodeInterval
Date
Msg-id CAAvxfHdrQc8pVoSnTPBfTKzHQzmYTg1qheNxMLoWDcrWpTJapg@mail.gmail.com
Whole thread Raw
In response to Re: Fix overflow in DecodeInterval  (Andres Freund <andres@anarazel.de>)
Responses Re: Fix overflow in DecodeInterval  (Joseph Koshakow <koshy44@gmail.com>)
Re: Fix overflow in DecodeInterval  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Sat, Feb 12, 2022 at 10:51 PM Andres Freund <andres@anarazel.de> wrote:
> Any reason for using int return types?
>
> particularly since the pg_*_overflow stuff uses bool?

I chose int return types to keep all these methods
consistent with DecodeInterval, which returns a
non-zero int to indicate an error. Though I wasn't sure
if an int or bool would be best, so I'm happy to change
to bool if people think that's better.

Also I'm realizing now that I've incorrectly been using the
number of the patch to indicate the version, instead of just
sticking a v3 to the front. So sorry about that, all the patches
I sent in this thread are the same patch, just different versions.

- Joe Koshakow



pgsql-hackers by date:

Previous
From: Yura Sokolov
Date:
Subject: Re: Error "initial slot snapshot too large" in create replication slot
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.