Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated
Date
Msg-id CAApHDvrtmqW_m9UMf37Fk_qgX6Voy_AX6-YVzj=-=HZJk-1tpg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-committers
Tree view 
On Tue, 10 May 2022 at 21:45, John Naylor <john.naylor@enterprisedb.com> wrote:
>
> On Tue, May 10, 2022 at 3:46 PM David Rowley <dgrowleyml@gmail.com> wrote:
> > What do you think?
>
> +1

Thanks for having a look.

I pushed this after I made a small adjustment to #ifdef out the
qsort_tuple_signed sort specialization in 32-bit builds.  On testing a
32-bit build with the patch I proposed, I was getting a warning about
that function being unused.

I found the 32-bit postgres binary is now an entire 4376 bytes smaller!

David

pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix some incorrect preprocessor tests in tuplesort specializatio
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve setup of environment values for commands in MSVC's vcreg