Postgres Pro
Downloads
Home   >   mailing lists

Re: ExecRTCheckPerms() and many prunable partitions - Mailing list pgsql-hackers

From David Rowley
Subject Re: ExecRTCheckPerms() and many prunable partitions
Date
Msg-id CAApHDvrU9Hp2AbVM0vKgOcaNgpDQQgKyYu8DPvFD3hBQGC5g+A@mail.gmail.com
Whole thread Raw
In response to ExecRTCheckPerms() and many prunable partitions  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: ExecRTCheckPerms() and many prunable partitions  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, 1 Jul 2021 at 01:34, Amit Langote <amitlangote09@gmail.com> wrote:
> For now, I have implemented the idea 2 as the attached patch.

I only just had a fleeting glance at the patch. Aren't you
accidentally missing the 0th RTE here?

+ while ((rti = bms_next_member(checkPermRels, rti)) > 0)
  {
- RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
+ RangeTblEntry *rte = (RangeTblEntry *) list_nth(rangeTable, rti - 1);

I'd have expected >= 0 rather than > 0.

David

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?
Next
From: Alexander Pyhalov
Date:
Subject: Re: Partitioned index can be not dumped