Postgres Pro
Downloads
Home   >   mailing lists

Re: add modulo (%) operator to pgbench - Mailing list pgsql-hackers

From David Rowley
Subject Re: add modulo (%) operator to pgbench
Date
Msg-id CAApHDvrRMadf9BTSuMXsNJbx2Psz9fHiKFPcxWKOMO5F9sOfvA@mail.gmail.com
Whole thread Raw
In response to Re: add modulo (%) operator to pgbench  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: add modulo (%) operator to pgbench
Re: add modulo (%) operator to pgbench
Re: add modulo (%) operator to pgbench
List pgsql-hackers
Tree view
On 1 January 2015 at 21:23, Fabien COELHO <coelho@cri.ensmp.fr> wrote:

I was about to go and look at this, but I had a problem when attempting to
compile with MSVC.

 Thanks! Here is a v4 which includes your fix.


I'm also just looking at you ERROR() macro, it seems that core code is quite careful not to use __VA_ARGS__ on compilers where HAVE__VA_ARGS is not defined. I'd say this needs to be fixed too. Have a look at the trick used in elog.h for when HAVE__VA_ARGS  is not defined.

Regards

David Rowley

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Next
From: Fujii Masao
Date:
Subject: Re: Compression of full-page-writes