Postgres Pro
Downloads
Home   >   mailing lists

Is it worth adding Assert(false) for iso-8859-1 paths in print_path()? - Mailing list pgsql-hackers

From David Rowley
Subject Is it worth adding Assert(false) for iso-8859-1 paths in print_path()?
Date
Msg-id CAApHDvrNB2maad+O+rUGV1Fzj=WQHiJTXSfQx5KBFDxyfjmbeA@mail.gmail.com
Whole thread Raw
Responses Re: Is it worth adding Assert(false) for iso-8859-1 paths in print_path()?
Re: Is it worth adding Assert(false) for iso-8859-1 paths in print_path()?
List pgsql-hackers
Tree view 
In [1] Andrey highlighted that I'd forgotten to add print_path()
handling for TidRangePaths in bb437f995.

I know the OPTIMIZER_DEBUG code isn't exactly well used.  I never
personally use it and I work quite a bit in the planner, however, if
we're keeping it, I thought maybe we might get the memo of missing
paths a bit sooner if we add an Assert(false) in the default cases.

Is the attached worthwhile?

David

[1] https://www.postgresql.org/message-id/379082d6-1b6a-4cd6-9ecf-7157d8c08635@postgrespro.ru
Attachment

pgsql-hackers by date:

Previous
From: Fabrice Chapuis
Date:
Subject: wal recycling problem
Next
From: vignesh C
Date:
Subject: Re: Invalidate the subscription worker in cases where a user loses their superuser status