Re: jit and explain nontext - Mailing list pgsql-hackers

From David Rowley
Subject Re: jit and explain nontext
Date
Msg-id CAApHDvrMbS64A1kgj8C4hUaUd6n5uye7P1bJyn6zXuVq0mSwxQ@mail.gmail.com
Whole thread Raw
In response to Re: jit and explain nontext  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
On Sun, 18 Oct 2020 at 08:21, Justin Pryzby <pryzby@telsasoft.com> wrote:
>         /* don't print information if no JITing happened */
> -       if (!ji || ji->created_functions == 0)
> +       if (!ji || (ji->created_functions == 0 &&
> +                       es->format == EXPLAIN_FORMAT_TEXT))
>                 return;

Isn't that comment now outdated?

I imagine something more like; /* Only show JIT details when we jitted
something or when in non-text mode */ might be better after making
that code change.

David



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Assertion failure with LEFT JOINs among >500 relations
Next
From: Tom Lane
Date:
Subject: Re: Assertion failure with LEFT JOINs among >500 relations