Re: typedef struct WindowClause misleading comments - Mailing list pgsql-hackers

From David Rowley
Subject Re: typedef struct WindowClause misleading comments
Date
Msg-id CAApHDvrB83=+aG6JAXyhOtz4x_U3VAjOyBtJ=TGp=PQQDic5eA@mail.gmail.com
Whole thread
In response to typedef struct WindowClause misleading comments  (jian he <jian.universality@gmail.com>)
Responses Re: typedef struct WindowClause misleading comments
Re: typedef struct WindowClause misleading comments
List pgsql-hackers
On Tue, 9 Jun 2026 at 13:56, jian he <jian.universality@gmail.com> wrote:
> Query jumbling considers the ORDER BY clause; therefore, the comment
> below is inaccurate.
>
> /
>  * The information relevant for the query jumbling is the partition clause
>  * type and its bounds.
>  */

I think the comment should be deleted.  It's pretty obvious which
fields are used by looking at the pg_node_attr(query_jumble_ignore)
attributes.

David



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: typedef struct WindowClause misleading comments
Next
From: Chao Li
Date:
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns