Re: typedef struct WindowClause misleading comments - Mailing list pgsql-hackers

From Tom Lane
Subject Re: typedef struct WindowClause misleading comments
Date
Msg-id 892312.1781024089@sss.pgh.pa.us
Whole thread
In response to Re: typedef struct WindowClause misleading comments  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: typedef struct WindowClause misleading comments
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> On Tue, 9 Jun 2026 at 13:56, jian he <jian.universality@gmail.com> wrote:
>> Query jumbling considers the ORDER BY clause; therefore, the comment
>> below is inaccurate.
>> 
>> /
>> * The information relevant for the query jumbling is the partition clause
>> * type and its bounds.
>> */

> I think the comment should be deleted.  It's pretty obvious which
> fields are used by looking at the pg_node_attr(query_jumble_ignore)
> attributes.

+1.  There are also other comments about query jumbling in nodes/*.h that
seem pretty information-free now.  They might have been helpful before
we invented query_jumble_ignore and related annotations, but now they
seem just duplicative.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Joao Foltran
Date:
Subject: Re: [BUG] [PATCH] Allow physical replication slots to recover from archive after invalidation
Next
From: Tom Lane
Date:
Subject: Re: Fix missing semicolon in pl_gram.y for option_value rule