Re: Fix missing semicolon in pl_gram.y for option_value rule - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix missing semicolon in pl_gram.y for option_value rule
Date
Msg-id 892846.1781024629@sss.pgh.pa.us
Whole thread
In response to Re: Fix missing semicolon in pl_gram.y for option_value rule  (shaobo zhang <zshaoo224@gmail.com>)
Responses Re: Fix missing semicolon in pl_gram.y for option_value rule
List pgsql-hackers
shaobo zhang <zshaoo224@gmail.com> writes:
>> Why do we even need to care about that?
>> --
>> Michael

> Agreed, it's purely cosmetic. If there's no interest in this cleanup,
> I'm fine to withdraw it. Thanks both for looking.

My inner neatnik likes consistency, so in the abstract I'd rather have
the semicolon present.  But I agree with Michael that it's not worth
the overhead to do this sort of fix retail.  (BTW I've got little
confidence that there aren't other places needing the same fix.)

What I'd really like is an equivalent of pgindent for bison files,
so that we could enforce this sort of style rule automatically.
But I suppose that's more work than it's worth, too.  Unless someone
knows of an existing tool?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: typedef struct WindowClause misleading comments
Next
From: Álvaro Herrera
Date:
Subject: Re: pg_upgrade fails when FK constraint with same name exists on partitioned table and its partition