Re: Fix missing semicolon in pl_gram.y for option_value rule - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Fix missing semicolon in pl_gram.y for option_value rule
Date
Msg-id 0ae7286a-e24f-4dd0-8a17-f34a2c257bbd@eisentraut.org
Whole thread
In response to Re: Fix missing semicolon in pl_gram.y for option_value rule  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fix missing semicolon in pl_gram.y for option_value rule
List pgsql-hackers
On 09.06.26 19:03, Tom Lane wrote:
> shaobo zhang <zshaoo224@gmail.com> writes:
>>> Why do we even need to care about that?
>>> --
>>> Michael
> 
>> Agreed, it's purely cosmetic. If there's no interest in this cleanup,
>> I'm fine to withdraw it. Thanks both for looking.
> 
> My inner neatnik likes consistency, so in the abstract I'd rather have
> the semicolon present.  But I agree with Michael that it's not worth
> the overhead to do this sort of fix retail.  (BTW I've got little
> confidence that there aren't other places needing the same fix.)
> 
> What I'd really like is an equivalent of pgindent for bison files,
> so that we could enforce this sort of style rule automatically.
> But I suppose that's more work than it's worth, too.  Unless someone
> knows of an existing tool?

The release notes of bison 3.0 say

   Missing semicolons at the end of actions are no longer added (as 
announced
   in the release 2.5).

But apparently that is not in fact happening?




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Fix compiler warnings by using designated initializers
Next
From: Andres Freund
Date:
Subject: Re: ci: Generate crashlogs on Windows