typedef struct WindowClause misleading comments - Mailing list pgsql-hackers

From jian he
Subject typedef struct WindowClause misleading comments
Date
Msg-id CACJufxEWeP2SLVMsbFNynd0pQnwbxh6U-v1nq5ccf9mSvBZntw@mail.gmail.com
Whole thread
Responses Re: typedef struct WindowClause misleading comments
List pgsql-hackers
Hi.

Query jumbling considers the ORDER BY clause; therefore, the comment
below is inaccurate.

/
 * The information relevant for the query jumbling is the partition clause
 * type and its bounds.
 */
typedef struct WindowClause
{
    NodeTag        type;
    /* window name (NULL in an OVER clause) */
    char       *name pg_node_attr(query_jumble_ignore);
    /* referenced window name, if any */
    char       *refname pg_node_attr(query_jumble_ignore);
    List       *partitionClause;    /* PARTITION BY list */
    /* ORDER BY list */
    List       *orderClause;
    int            frameOptions;    /* frame_clause options, see WindowDef */
    Node       *startOffset;    /* expression for starting bound, if any */
    Node       *endOffset;        /* expression for ending bound, if any */
   .....
}



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and -DEXEC_BACKEND at startup
Next
From: David Rowley
Date:
Subject: Re: typedef struct WindowClause misleading comments