Re: B-Tree support function number 3 (strxfrm() optimization) - Mailing list pgsql-hackers

From David Rowley
Subject Re: B-Tree support function number 3 (strxfrm() optimization)
Date
Msg-id CAApHDvr9rJmfi-zYbfe0hPt2ArppDB85u-6N-2Hn4j8oOaCypQ@mail.gmail.com
Whole thread Raw
In response to Re: B-Tree support function number 3 (strxfrm() optimization)  (Peter Geoghegan <pg@heroku.com>)
Responses Re: B-Tree support function number 3 (strxfrm() optimization)
List pgsql-hackers
On 20 January 2015 at 17:10, Peter Geoghegan <pg@heroku.com> wrote:
On Mon, Jan 19, 2015 at 7:47 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

> With your patch applied, the failure with MSVC disappeared, but there
> is still a warning showing up:
> (ClCompile target) ->
>   src\backend\lib\hyperloglog.c(73): warning C4334: '<<' : result of
> 32-bit shift implicitly converted to 64 bits (was 64-bit shift
> intended?

That seems harmless. I suggest an explicit cast to "Size" here.

This caught my eye too.

I agree about casting to Size.

Patch attached.

Regards

David Rowley 
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Proposal: knowing detail of config files via SQL
Next
From: Noah Misch
Date:
Subject: Re: jsonb, unicode escapes and escaped backslashes