On Tue, 30 Sept 2025 at 12:40, Michael Paquier <michael@paquier.xyz> wrote:
> The only two code paths I'm seeing as not covered are:
> - test_bms_add_range() for a bms_free() case.
One question about that: In cases like [1], what's the reason that
many of the bms_free() calls check if the set is NULL before calling
the function?
NULL is a valid Bitmapset, so I don't really see the need to check for
an empty set before calling bms_free(). If those were removed, then
you'd not have to care about the coverage of that line.
David
[1] https://coverage.postgresql.org/src/test/modules/test_bitmapset/test_bitmapset.c.gcov.html#699
