Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id aNspd6syEndiEPNj@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: [PATCH] Add tests for Bitmapset
List pgsql-hackers
On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote:
> NULL is a valid Bitmapset, so I don't really see the need to check for
> an empty set before calling bms_free().  If those were removed, then
> you'd not have to care about the coverage of that line.

Yeah, we could just remove them as you are suggesting, as well.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Incorrect logic in XLogNeedsFlush()
Next
From: Yugo Nagata
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench