Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id aNsYzCYjPV2VQd3o@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (Greg Burd <greg@burd.me>)
Responses Re: [PATCH] Add tests for Bitmapset
List pgsql-hackers
On Mon, Sep 29, 2025 at 06:27:01AM -0400, Greg Burd wrote:
> Yes, I think that does it.  Thanks so much for the guidance and help
> taking this to its logical end.  I greatly appreciate your guidance and time.

The latest coverage report confirms 100% for bitmapset.c

The only two code paths I'm seeing as not covered are:
- test_bms_add_range() for a bms_free() case.
- test_bms_make_singleton() on NULL input, because the function is
created as strict:
=# select proisstrict from pg_proc
     where proname = 'test_bms_make_singleton';
 proisstrict
-------------
 t
(1 row)

I'm not planning to bother about these, so we are good here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Support getrandom() for pg_strong_random() source
Next
From: Chao Li
Date:
Subject: Re: [PATCH] GROUP BY ALL