Re: Adjust Memoize hit_ratio calculation - Mailing list pgsql-hackers

From David Rowley
Subject Re: Adjust Memoize hit_ratio calculation
Date
Msg-id CAApHDvqOm_ANNwXdJQFSA2g_tszgDeWGJ+_M3FiyUzN9XnEutw@mail.gmail.com
Whole thread Raw
In response to Adjust Memoize hit_ratio calculation  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Tue, 21 Mar 2023 at 09:41, David Rowley <dgrowleyml@gmail.com> wrote:
> Because that's being changed in v16, I think it might also be a good
> idea to fix the hit_ratio calculation problem reported by David
> Johnston in [1].  In the attached, I've adjusted David's calculation
> slightly so that we divide by Max(ndistinct, est_cache_entries)
> instead of ndistinct.  This saves from overestimating when ndistinct
> is smaller than est_cache_entries.  I'd rather fix this now for v16
> than wait until v17 and further adjust the Memoize costing.

I've now pushed this change.

David



pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Add SHELL_EXIT_CODE to psql
Next
From: Andres Freund
Date:
Subject: Re: Save a few bytes in pg_attribute