Re: Fix BUG #17335: Duplicate result rows in Gather node - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix BUG #17335: Duplicate result rows in Gather node
Date
Msg-id CAApHDvqEnKn_Y4nNPqCPRLkwxZWS3tNPU6VxB9P1QtiN8y3onw@mail.gmail.com
Whole thread Raw
In response to Re: Fix BUG #17335: Duplicate result rows in Gather node  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Fix BUG #17335: Duplicate result rows in Gather node
List pgsql-hackers
On Tue, 25 Jan 2022 at 20:03, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Tue, 25 Jan 2022 at 17:35, Yura Sokolov <y.sokolov@postgrespro.ru> wrote:
> > And another attempt to fix tests volatility.
>
> FWIW, I had not really seen the point in adding a test for this.   I
> did however see a point in it with your original patch. It seemed
> useful there to verify that Gather and GatherMerge did what we
> expected with 1 worker.

I ended up pushing just the last patch I sent.

The reason I didn't think it was worth adding a new test was that no
tests were added in the original commit.  Existing tests did cover it,
but here we're just restoring the original behaviour for one simple
case.  The test in your patch just seemed a bit more hassle than it
was worth. I struggle to imagine how we'll break this again.

David



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: missing indexes in indexlist with partitioned tables
Next
From: Peter Eisentraut
Date:
Subject: libpq async duplicate error results