Re: pgsql: Fix list_copy_head() with empty Lists - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Fix list_copy_head() with empty Lists
Date
Msg-id CAApHDvq1Lz9DSiBxkK_pgv1ky5V8L7gGkbto1HNgEpLyKtYS8w@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix list_copy_head() with empty Lists  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix list_copy_head() with empty Lists
List pgsql-committers
On Fri, 21 Apr 2023 at 01:28, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I see that list_copy_head exists in v15 as well.  It appears to have
> no callers there, but we'd better fix it anyway in case somebody
> back-patches a fix that uses it.

Doh :-(   Thanks for alerting me.  I've just applied the patch to REL_15_STABLE.

I kept the same commit message as master, which I think was the
correct thing to do, despite it containing information that wasn't
true.  I know the script used to assist release note creation goes on
commit messages to determine which commits went into which branches.

> Or, maybe, remove it in 15?

I chickened out of that as it does not seem impossible that someone is
making use of it.  It seems lightweight enough not to have to worry
too much about keeping it around.

David



pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix list_copy_head() with empty Lists
Next
From: Tom Lane
Date:
Subject: pgsql: Use --strip-unneeded when stripping static libraries with GNU st