Re: ExecRTCheckPerms() and many prunable partitions - Mailing list pgsql-hackers

From David Rowley
Subject Re: ExecRTCheckPerms() and many prunable partitions
Date
Msg-id CAApHDvpzCbPGGtrF7xaVNjP11HJDgK=nqaZqcE6QkhOXf_+Lqw@mail.gmail.com
Whole thread Raw
In response to Re: ExecRTCheckPerms() and many prunable partitions  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
On Thu, 1 Jul 2021 at 02:58, Amit Langote <amitlangote09@gmail.com> wrote:
>
> On Wed, Jun 30, 2021 at 23:34 David Rowley <dgrowleyml@gmail.com> wrote:
>> + while ((rti = bms_next_member(checkPermRels, rti)) > 0)
>>   {
>> - RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
>> + RangeTblEntry *rte = (RangeTblEntry *) list_nth(rangeTable, rti - 1);
>>
>> I'd have expected >= 0 rather than > 0.
>
> Hmm, a valid RT index cannot be 0, so that seems fine to me.  Note that RT indexes are added as-is to that bitmapset,
notafter subtracting 1.
 

Oh, you're right. My mistake.

David



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: New committers: Daniel Gustafsson and John Naylor
Next
From: David Rowley
Date:
Subject: Re: Small clean up in nodeAgg.c