Re: Fix grammar oddities in comments - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix grammar oddities in comments
Date
Msg-id CAApHDvpKdiEHcGs_jX2dijsx-N8eWhDoyU7BqHFoYT=p3au-MA@mail.gmail.com
Whole thread Raw
In response to Fix grammar oddities in comments  (James Coleman <jtc331@gmail.com>)
Responses Re: Fix grammar oddities in comments
Re: Fix grammar oddities in comments
List pgsql-hackers
On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331@gmail.com> wrote:
> See attached for a small patch fixing some typos and grammatical
> errors in a couple of comments.

Thanks. I pushed this after messing with the comments a bit more.

> Side note: It's not clear to me what "Vars of higher levels don't
> matter here" means in this context (or how that claim is justified),
> but I haven't changed that part of the comment opting to simply
> resolve the clear mistakes in the wording here.

It just means Vars with varlevelsup >= 2 don't matter. It only cares
about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct
parent.

David



pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: meson "experimental"?
Next
From: Richard Guo
Date:
Subject: Re: Wrong results with grouping sets