Re: shadow variables - pg15 edition - Mailing list pgsql-hackers

From David Rowley
Subject Re: shadow variables - pg15 edition
Date
Msg-id CAApHDvpFy3Bve8q+gKTFygGd+vr4oUb7mf2ogDhju_bp=7r88g@mail.gmail.com
Whole thread Raw
In response to Re: shadow variables - pg15 edition  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: shadow variables - pg15 edition  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Thu, 6 Oct 2022 at 11:50, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Thu, 6 Oct 2022 at 10:40, Andres Freund <andres@anarazel.de> wrote:
> > Your commit message said the last shadowed variable. But building with
> > -Wshadow=compatible-local triggers a bunch of warnings for me (see trimmed at
> > the end).  Looks like it "only" fixed it for src/, without optional
> > dependencies like gssapi and python.
>
> Well, that's embarrassing. You're right. I only fixed the ones I saw
> from running make in the base directory of the tree.  I'll set about
> fixing these nownow.

Here's a patch which (I think) fixes the ones I missed.

David

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Move backup-related code to xlogbackup.c/.h
Next
From: Michael Paquier
Date:
Subject: Re: Add meson.build to version_stamp.pl