On Fri, 2 Feb 2024 at 23:39, David Rowley <dgrowleyml@gmail.com> wrote:
> I'll push the patch shortly.
I've pushed the partial path sort part.
Now for the other stuff you had. I didn't really like this part:
+ /*
+ * Set target for partial_distinct_rel as generate_useful_gather_paths
+ * requires that the input rel has a valid reltarget.
+ */
+ partial_distinct_rel->reltarget = cheapest_partial_path->pathtarget;
I think we should just make it work the same way as
create_grouping_paths(), where grouping_target is passed as a
parameter.
I've done it that way in the attached.
David