Re: A problem in ExecModifyTable - Mailing list pgsql-hackers

From David Rowley
Subject Re: A problem in ExecModifyTable
Date
Msg-id CAApHDvp8yh9etjk0i6-oVEm=rfJ7k_9+eJEFg-8dFmyg7bEASg@mail.gmail.com
Whole thread Raw
In response to 回复:A problem in ExecModifyTable  ("李杰(慎追)" <adger.lj@alibaba-inc.com>)
Responses Re: A problem in ExecModifyTable  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, 17 Aug 2021 at 19:06, 李杰(慎追) <adger.lj@alibaba-inc.com> wrote:
>     Your answer explains that we still need to ModifyTable node without Leaf partitions.
>     You are right about this.
>
>      But you can review the source code again,

I'd been looking at the code in ExecInitModifyTable() that's the same
as what you pasted thinking you meant that.  I think for the check for
partitioned tables in ExecModifyTable() then it's likely just dead
code.  It seems to be causing a bit of confusion though, so might be
worth doing something about. Copied in Tom to see what he thinks as
it's one of his.

David



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Next
From: Ekaterina Sokolova
Date:
Subject: Re: [PATCH] Add extra statistics to explain for Nested Loop