Re: BUG #17967: [msvc-x86] Failed to build with error LNK2019: unresolved external symbol __BitScanReverse64 referen - Mailing list pgsql-bugs

From David Rowley
Subject Re: BUG #17967: [msvc-x86] Failed to build with error LNK2019: unresolved external symbol __BitScanReverse64 referen
Date
Msg-id CAApHDvp3s9ObJZdEsUfuUnrxmZhD3qS3DNcXt+Ac96gYFASa1Q@mail.gmail.com
Whole thread Raw
In response to BUG #17967: [msvc-x86] Failed to build with error LNK2019: unresolved external symbol __BitScanReverse64 referen  (PG Bug reporting form <noreply@postgresql.org>)
Responses Re: BUG #17967: [msvc-x86] Failed to build with error LNK2019: unresolved external symbol __BitScanReverse64 referen  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-bugs
On Wed, 7 Jun 2023 at 23:26, PG Bug reporting form
<noreply@postgresql.org> wrote:
> The file `src/bin/pg_verifybackup/pg_verifybackup.c` fails to compile using
> msvc under x86, there is no `_BitScanForward64` and `_BitScanReverse64`
> under **x86** for head `src/include/port/pg_bitutils.h`.

I guess not many people are building on 32-bit MSVC these days.

I've not tested it, but I imagine the attached patch should fix it.

The ARM-64 part I included in the patch is just future-proofing.
Maybe I shouldn't bother with it.

David

Attachment

pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: BUG #17964: Missed query planner optimization
Next
From: Mathias Kunter
Date:
Subject: Re: BUG #17964: Missed query planner optimization