Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h - Mailing list pgsql-hackers

From David Rowley
Subject Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h
Date
Msg-id CAApHDvp0fSDD8nswhmZZPJ=J5haNaAN=UuymYst+jmF-2wvc+g@mail.gmail.com
Whole thread Raw
In response to Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Mon, 12 Aug 2024 at 22:32, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Mon, 12 Aug 2024 at 22:03, jian he <jian.universality@gmail.com> wrote:
> > I think first ri_RowIdAttNo applies to MERGE also. so the comments may
> > not be correct?
>
> Yeah, ri_RowIdAttNo is used for MERGE. We should fix that comment.
>
> > Other files comments are fine.
>
> I'd say ri_GeneratedExprsI and ri_GeneratedExprsU are also used for
> MERGE and the comment for those is also outdated. See:

I've pushed a patch to fix these.  Thanks for the report.

David



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Conflict detection and logging in logical replication
Next
From: Alena Rybakina
Date:
Subject: Re: Add support for (Var op Var) clause in extended MCV statistics