Re: Remove redundant initializations - Mailing list pgsql-hackers

From David Rowley
Subject Re: Remove redundant initializations
Date
Msg-id CAApHDvotvHn4Q8wELdKeLX9K7WQKWhQYhsxDvSfw9D3pdtFqgQ@mail.gmail.com
Whole thread Raw
In response to Re: Remove redundant initializations  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remove redundant initializations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, 29 Jun 2021 at 02:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> The primary case where I personally rely on that style is when adding a
> new field to a struct.  Currently it's possible to grep for some existing
> field and add the new one beside it.  Leaving out initializations by
> relying on side-effects of makeNode makes that far riskier.

FWIW, I mostly grep for makeNode(NameOfNode) as I'm a bit mistrusting
of if the random existing field name that I pick to grep for will
properly showing me all the locations I should touch.

David



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: cleaning up PostgresNode.pm
Next
From: Andrey Lepikhov
Date:
Subject: Re: Merging statistics from children instead of re-sampling everything