Re: set_cheapest without checking pathlist - Mailing list pgsql-hackers

From David Rowley
Subject Re: set_cheapest without checking pathlist
Date
Msg-id CAApHDvoqbAv333b0kaR-8Yy0FECeYfPqTf5K23z+QqOt_KBCKw@mail.gmail.com
Whole thread Raw
In response to Re: set_cheapest without checking pathlist  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: set_cheapest without checking pathlist
List pgsql-hackers
On Thu, 1 Feb 2024 at 19:36, Richard Guo <guofenglinux@gmail.com> wrote:
> maybe we can add an Assert or a comment clarifying that the pathlist of
> partially_grouped_rel cannot be empty here.

There'd be no need to Assert that as set_cheapest() will raise an
error when given a rel with an empty pathlist.

I don't think putting an Assert that would fail in the same situation
that we'd later ERROR out on would be a good idea. It'd make it harder
to debug the issue.

David



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: A performance issue with Memoize
Next
From: Amit Kapila
Date:
Subject: Re: Synchronizing slots from primary to standby