Re: pgsql: Expose internal function for converting int64 to numeric - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Expose internal function for converting int64 to numeric
Date
Msg-id CAApHDvofA_vsrpC13mq_hZyuye5B-ssKEaer04OouXYCO5-uXQ@mail.gmail.com
Whole thread Raw
In response to pgsql: Expose internal function for converting int64 to numeric  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-committers
On Thu, 10 Sep 2020 at 06:41, Peter Eisentraut <peter@eisentraut.org> wrote:
> src/backend/utils/adt/dbsize.c        |  21 ++----

This change introduced a new compiler warning on MSVC.

src\backend\utils\adt\dbsize.c(630): warning C4334: '<<': result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)

I see all of the calls all bit shift by a constant that''s always
below 32. So there's no actual danger here, but the attached at least
silences the warning.

I'll push it in a bit if nobody has other ideas.

David

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Stamp 13rc1.
Next
From: David Rowley
Date:
Subject: pgsql: Fix compiler warning