Re: [PATCH] Move clause_sides_match_join() into pathnode.h - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Move clause_sides_match_join() into pathnode.h
Date
Msg-id CAApHDvocwWdcXZEGRVtL3iv_ZAbaB+Gh7MGk8AovhLCMxskHrA@mail.gmail.com
Whole thread Raw
List pgsql-hackers
On Thu, 10 Oct 2024 at 08:38, James Hunter <james.hunter.pg@gmail.com> wrote:
> We had two almost-identical copies of the utility function
> clause_sides_match_join() -- one in joinpath.c, and one in
> analyzejoins.c. Both copies were marked "inline," so we might as well
> just move the (inline) function definition into a common header file.
> I chose pathnode.h, because it is already #included by both of the .c
> files.

I'm in favour of the deduplication.  pathnode.h seems like a strange
choice. restrictinfo.h seems more suited.

(I really wonder how much the inlining is giving us given that the
function itself calls other non-inlineable functions)

David



pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Re: Official devcontainer config
Next
From: Richard Guo
Date:
Subject: Re: Inconsistent RestrictInfo serial numbers