Open Item: Should non-text EXPLAIN always show properties? - Mailing list pgsql-hackers

From David Rowley
Subject Open Item: Should non-text EXPLAIN always show properties?
Date
Msg-id CAApHDvo_dmNozQQTmN-2jGp1vT=dxx7Q0vd+MvD1cGpv2HU=Sg@mail.gmail.com
Whole thread Raw
Responses Re: Open Item: Should non-text EXPLAIN always show properties?  (James Coleman <jtc331@gmail.com>)
Re: Open Item: Should non-text EXPLAIN always show properties?  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Over on [1] Justin mentions that the non-text EXPLAIN ANALYZE should
always show the "Disk Usage" and "HashAgg Batches" properties.  I
agree with this. show_wal_usage() is a good example of how we normally
do things.  We try to keep the text format as humanly readable as
possible but don't really expect humans to be commonly reading the
other supported formats, so we care less about including additional
details there.

There's also an open item regarding this for Incremental Sort, so I've
CC'd James and Tomas here. This seems like a good place to discuss
both.

I've attached a small patch that changes the Hash Aggregate behaviour
to always show these properties for non-text formats.

Does anyone object to this?

David

[1] https://www.postgresql.org/message-id/20200619040624.GA17995%40telsasoft.com

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Missing some ifndef FRONTEND at the top of logging.c andfile_utils.c
Next
From: David Rowley
Date:
Subject: Re: Why forbid "INSERT INTO t () VALUES ();"