Re: pgsql: Add DISTINCT to information schema usage views - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Add DISTINCT to information schema usage views
Date
Msg-id CAApHDvoT1fXHAanzJSWLmLsu8KJ3EUATtVE1nuwHsgse66EOgw@mail.gmail.com
Whole thread Raw
In response to pgsql: Add DISTINCT to information schema usage views  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-committers
On Wed, 21 Apr 2021 at 22:32, Peter Eisentraut <peter@eisentraut.org> wrote:
> Add DISTINCT to information schema usage views

What do you think of the idea of just getting rid of all these
DISTINCTs and instead do a semi-join so that we don't get duplicate
rows?

For me, I don't really like the DISTINCTs as the behaviour is prone to
change as the target list changes in the view.  Maybe these views are
standard enough that that's not going to happen very often, but it
could.

The 2nd reason I'm not a fan of using DISTINCT is that it's really
chopping the problem off at the tail instead of the head.

I've attached a patch that gets rid of all the DISTINCTs.

David

Attachment

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Add DISTINCT to information schema usage views
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Only ever test for non-127.0.0.1 addresses on Windows in Postgre