Re: pgsql: Improve PQtrace() output format - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Improve PQtrace() output format
Date
Msg-id CAApHDvoRG25X_=ZCGSPb4KN_j2iu=G2uXsRSg8NBZeuhkOSETg@mail.gmail.com
Whole thread Raw
In response to pgsql: Improve PQtrace() output format  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Improve PQtrace() output format  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Wed, 31 Mar 2021 at 12:17, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> Improve PQtrace() output format

I see the Visual Studio buildfarm members have been getting a compiler
warning since this commit [1]

(ClCompile target) ->
  src/interfaces/libpq/fe-trace.c(87): warning C4133: 'function':
incompatible types - from 'long *' to 'const time_t *const '
[C:\\pgbuildfarm\\pgbuildroot\\HEAD\\pgsql.build\\libpq.vcxproj]

It looks like this is due to long being 32-bits on Visual Studio.

We could just assign tval.tv_sec to a local time_t value to get rid of
it.  See attached.

David

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=dory&dt=2021-04-06%2001%3A00%3A07&stg=make

Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix some issues with SSL and Kerberos tests
Next
From: Fujii Masao
Date:
Subject: pgsql: Add function to log the memory contexts of specified backend pro