Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
Date
Msg-id CAApHDvoDqCko=wRx6hJ6DsNAGA10+qWYDtZJLG4HdKWACPv=ow@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-committers
On Tue, 11 Apr 2023 at 13:23, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
> This commit added the following error message.
>
> >                errmsg("value: \"%s\": is invalid for buffer_usage_limit",
>
> It looks as the follows on terminal.
>
> postgres=# vacuum (buffer_usage_limit 'x');
> ERROR:  value: "x": is invalid for buffer_usage_limit
>
> I'm not sure why the message has two colons.  [1] talks about the
> message but doesn't really explain the reason for this.

Probably we can use what a GUC like work_mem does for this case:

postgres=# set work_mem = 'x';
ERROR:  invalid value for parameter "work_mem": "x"

with the attached, what you tried becomes:

postgres=# vacuum (buffer_usage_limit 'x');
ERROR:  invalid value for "buffer_usage_limit": "x"

How's that?

David

Attachment

pgsql-committers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option