Re: [PATCH] Small optimization across postgres (remove strlenduplicate usage) - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Small optimization across postgres (remove strlenduplicate usage)
Date
Msg-id CAApHDvo5rrUpOzQZogwEV5ZNteE4bTZNbWN4WUFza8oinGxy0A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Small optimization across postgres (remove strlen duplicate usage)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Small optimization across postgres (remove strlenduplicate usage)
List pgsql-hackers
On Mon, 20 Apr 2020 at 09:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> The cases where Ranier proposes to replace strlen(foo) == 0
> with a test on foo[0] do seem like wins, though.  Asking for
> the full string length to be computed is more computation than
> necessary, and it's less clear that the compiler could be
> expected to save you from that.  Anyway there's a coding style
> proposition that we should be doing this consistently, and
> certainly lots of places do do this without using strlen().

Looking at https://godbolt.org/z/6XsjbA it seems like GCC is pretty
good at getting rid of the strlen call even at -O0. It takes -O1 for
clang to use it and -O2 for icc.

David



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Small optimization across postgres (remove strlen duplicate usage)
Next
From: Jeff Davis
Date:
Subject: v13: Performance regression related to FORTIFY_SOURCE