Re: missing rename support - Mailing list pgsql-hackers

From Ali Dar
Subject Re: missing rename support
Date
Msg-id CAAj60S4wC=Cwao082t8BATx9aeHmBr3H49GJcbfb-tjMhYOeLw@mail.gmail.com
Whole thread Raw
In response to Re: missing rename support  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: missing rename support
List pgsql-hackers
Please find attached the complete patch for alter rename rule. I have followed all the suggestions. Followings things are added in this updated patch:
1) Disallow alter rename of ON SELECT rules.
2) Remove warning.
3) Varibles are lined up.
4) Used qualified_name instead of makeRangeVarFromAnyName.
5) Throw appropriate error if user tries to alter rename rule on irrelavent object(e.g index).
6) Psql tab support added
7) Regression test cases added.
8) Documentation added.

Regards,
Ali Dar


On Mon, Jan 21, 2013 at 12:34 AM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
On 3 January 2013 13:49, Ali Dar <ali.munir.dar@gmail.com> wrote:
> Find attached an initial patch for ALTER RENAME RULE feature. Please note
> that it does not have any documentation yet.
>

Hi,

I just got round to looking at this. All-in-all it looks OK. I just
have a few more review comments, in addition to Stephen's comment
about renaming SELECT rules...

This compiler warning should be fixed with another #include:
alter.c:107:4: warning: implicit declaration of function ‘RenameRewriteRule’

In gram.y, I think you can just use qualified_name instead of
makeRangeVarFromAnyName().

In RenameRewriteRule(), I think it's worth doing a check to ensure
that the relation actually is a table or a view (you might have some
other relation kind at that point in the code). If the user
accidentally types the name of an index, say, instead of a table, then
it is better to throw an error saying "xxx is not a table or a view"
rather than reporting that the rule doesn't exist.

I think this could probably use some simple regression tests to test
both the success and failure cases.

It would be nice to extend psql tab completion to support this too,
although perhaps that could be done as a separate patch.

Don't forget the docs!

Regards,
Dean

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: psql \l to accept patterns
Next
From: Fujii Masao
Date:
Subject: Re: Back-branch update releases coming in a couple weeks